| From: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Enable -Wstrict-prototypes and -Wold-style-definition by default |
| Date: | 2026-03-25 03:17:35 |
| Message-ID: | acNTz11huUuTTgx9@ip-10-97-1-34.eu-west-3.compute.internal |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Tue, Mar 24, 2026 at 10:36:43PM +0100, Peter Eisentraut wrote:
> On 24.03.26 08:16, Bertrand Drouvot wrote:
> > 0001:
> >
> > + '/external:anglebrackets',
> > + '/external:W0',
> >
> > The doc [1], states:
> >
> > "
> > The /external compiler options are available starting in Visual Studio 2017 version 15.6.
> > In versions of Visual Studio before Visual Studio 2019 version 16.10, the /external
> > options require you also set the /experimental:external compiler option.
> > "
> >
> > We currently require MSVC 2019, but what if one is using a version < 16.10?
>
> Per discussion in [0] we effectively require 16.11, so I think this should
> be ok.
Agree, thanks for the link!
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | getiancheng | 2026-03-25 03:22:30 | Re: [PATCH] Fix premature timeout in pg_promote() caused by signal interruptions |
| Previous Message | Fujii Masao | 2026-03-25 03:16:30 | Re: Reduce log level of some logical decoding messages to DEBUG1 |