Re: Enable -Wstrict-prototypes and -Wold-style-definition by default

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Enable -Wstrict-prototypes and -Wold-style-definition by default
Date: 2026-03-24 21:36:43
Message-ID: 6edd397a-dd66-4f0d-ac58-4193fb1ea3dd@eisentraut.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 24.03.26 08:16, Bertrand Drouvot wrote:
> 0001:
>
> + '/external:anglebrackets',
> + '/external:W0',
>
> The doc [1], states:
>
> "
> The /external compiler options are available starting in Visual Studio 2017 version 15.6.
> In versions of Visual Studio before Visual Studio 2019 version 16.10, the /external
> options require you also set the /experimental:external compiler option.
> "
>
> We currently require MSVC 2019, but what if one is using a version < 16.10?

Per discussion in [0] we effectively require 16.11, so I think this
should be ok.

[0]:
https://www.postgresql.org/message-id/04ab76a3-186c-4a37-8076-e6882ebf9d43%40eisentraut.org

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2026-03-24 21:42:45 Re: Introduce XID age based replication slot invalidation
Previous Message Andres Freund 2026-03-24 21:30:46 Test timings are increasing too fast for cfbot