Re: update tuple routing and triggers

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
Subject: Re: update tuple routing and triggers
Date: 2018-02-08 01:26:20
Message-ID: ac8f87eb-eea5-bbd0-81f8-9d9a19aefd41@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thanks for the review.

On 2018/02/08 0:04, Robert Haas wrote:
> On Tue, Feb 6, 2018 at 12:52 AM, Amit Langote
> <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> About renaming es_leaf_result_relations to
>> es_tuple_routing_result_relations, I will defer that to committer. But on
>> second though, maybe we don't need to make this patch larger than it has
>> to be.
>
> +1 for renaming it. I like keeping the patch small, but not at the
> price of being misleading.

OK, done in the attached.

> + /*
> + * Since we're newly creating this ResultRelInfo, add it to
> + * someplace where others could find it.
> + */
>
> How about: "Since we've just initialized this ResultRelInfo, it's not
> in any list attached to the estate as yet. Add it, so that it can be
> found later."

Wrote that way.

Thanks,
Amit

Attachment Content-Type Size
v4-0001-Fix-trigger-behavior-with-update-tuple-routing.patch text/plain 4.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2018-02-08 01:40:41 Re: postgres_fdw: perform UPDATE/DELETE .. RETURNING on a join directly
Previous Message Tom Lane 2018-02-08 00:41:48 Re: PostgreSQL crashes with SIGSEGV