Re: Regression tests fail with musl libc because libpq.so can't be loaded

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Christophe Pettus <xof(at)thebuild(dot)com>, Wolfgang Walther <walther(at)technowledgy(dot)de>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Bugs <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: Re: Regression tests fail with musl libc because libpq.so can't be loaded
Date: 2024-03-20 06:02:48
Message-ID: ac80cff7-cc8f-4eee-ba4f-12d0fc902e0c@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On 17.03.24 11:33, Christophe Pettus wrote:
>> On Mar 17, 2024, at 02:44, Wolfgang Walther <walther(at)technowledgy(dot)de> wrote:
>>
>> Nailed it. PS_USE_NONE fixes it.
>
> Given the musl (still?) does not define a preprocessor macro specific to it, is there a way of improving the test in pg_status.c to catch this case? It seems wrong that the current test passes a case that doesn't actually work.
>

We could turn it around and do

#if defined(__linux__)
#if defined(__GLIBC__) || defined(__UCLIBC__ )
#define PS_USE_CLOBBER_ARGV
#else
#define PS_USE_NONE
#endif
#endif

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tender Wang 2024-03-20 06:22:28 Re: BUG #18396: Assert in gistFindCorrectParent() fails on inserting large tuples into gist index
Previous Message Alexander Lakhin 2024-03-20 05:00:00 Re: BUG #18396: Assert in gistFindCorrectParent() fails on inserting large tuples into gist index

Browse pgsql-hackers by date

  From Date Subject
Next Message Shlok Kyal 2024-03-20 06:14:24 Re: speed up a logical replica setup
Previous Message Bharath Rupireddy 2024-03-20 05:47:47 Re: Introduce XID age and inactive timeout based replication slot invalidation