| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Christophe Pettus <xof(at)thebuild(dot)com>, Wolfgang Walther <walther(at)technowledgy(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Bugs <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Regression tests fail with musl libc because libpq.so can't be loaded |
| Date: | 2024-03-20 07:16:14 |
| Message-ID: | CAD5tBcJwwTSwKUFkpo-zJSH4Mu1=Q2CsvNgiqJ44AOOAx-jbdA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Wed, Mar 20, 2024 at 2:03 AM Peter Eisentraut <peter(at)eisentraut(dot)org>
wrote:
> On 17.03.24 11:33, Christophe Pettus wrote:
> >> On Mar 17, 2024, at 02:44, Wolfgang Walther <walther(at)technowledgy(dot)de>
> wrote:
> >>
> >> Nailed it. PS_USE_NONE fixes it.
> >
> > Given the musl (still?) does not define a preprocessor macro specific to
> it, is there a way of improving the test in pg_status.c to catch this
> case? It seems wrong that the current test passes a case that doesn't
> actually work.
> >
>
> We could turn it around and do
>
> #if defined(__linux__)
> #if defined(__GLIBC__) || defined(__UCLIBC__ )
> #define PS_USE_CLOBBER_ARGV
> #else
> #define PS_USE_NONE
> #endif
> #endif
>
>
>
>
I like it. Neat and minimal.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Wolfgang Walther | 2024-03-20 09:39:20 | Re: Regression tests fail with musl libc because libpq.so can't be loaded |
| Previous Message | Sawyer Knoblich | 2024-03-20 06:37:17 | Re: BUG #18399: Query plan optimization results in runtime error when hoisting cast from inside subquery |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2024-03-20 07:19:39 | Re: WIP Incremental JSON Parser |
| Previous Message | Heikki Linnakangas | 2024-03-20 07:16:13 | Re: Refactoring backend fork+exec code |