| From: | "Maksim(dot)Melnikov" <m(dot)melnikov(at)postgrespro(dot)ru> |
|---|---|
| To: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com> |
| Cc: | Потапов Александр <a(dot)potapov(at)postgrespro(dot)ru>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Init connection time grows quadratically |
| Date: | 2026-08-07 14:05:05 |
| Message-ID: | ac72087f-0df9-4fbb-bb66-6b51ac9d1c08@postgrespro.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 7/17/26 11:54, Matthias van de Meent wrote:
> On Thu, 11 Jun 2026 at 16:31, Maksim.Melnikov <m(dot)melnikov(at)postgrespro(dot)ru> wrote:
>> Patch with fixes was attached. Thanks for review.
> You removed the pgxactoff field with its comment from PGPROC, but
> haven't yet added a comment on PROC_HDR's pgxactoffs. Please add a
> comment to the pgxactoffs array that describes its contents. A simple
> adaptation of the comment removed with PGPROC's pgxactoff field should
> be sufficient.
>
> The comments on PROC_HDR and PGPROC also reference the deleted
> PGPROC->pgxactoff field, so that also must be adjusted; there may be
> several other places, as I didn't do a full check on the codebase.
>
> Once the relevant comments are added and adjusted I think this is
> ready for a committer.
>
>
> Kind regards,
>
> Matthias van de Meent
> Databricks (https://www.databricks.com)
>
>
Sorry for the delay, was unavailable for several weeks.
Thanks for review, patch was updated.
Best regards,
Maksim Melnikov
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-This-patch-reduce-connection-init-close-time.patch | text/x-patch | 16.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2026-08-07 14:11:35 | Re: Proposal: Conflict log history table for Logical Replication |
| Previous Message | Andrey Borodin | 2026-08-07 13:59:02 | Re: serializable anomaly - duplicate primary keys |