| From: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com> |
|---|---|
| To: | "Maksim(dot)Melnikov" <m(dot)melnikov(at)postgrespro(dot)ru> |
| Cc: | Потапов Александр <a(dot)potapov(at)postgrespro(dot)ru>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Init connection time grows quadratically |
| Date: | 2026-07-17 08:54:45 |
| Message-ID: | CAEze2Wgyq-ArsJ_MbJj+hGxB=hZYXA3j51N_362EwN+hWPEEtw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 11 Jun 2026 at 16:31, Maksim.Melnikov <m(dot)melnikov(at)postgrespro(dot)ru> wrote:
>
> Patch with fixes was attached. Thanks for review.
You removed the pgxactoff field with its comment from PGPROC, but
haven't yet added a comment on PROC_HDR's pgxactoffs. Please add a
comment to the pgxactoffs array that describes its contents. A simple
adaptation of the comment removed with PGPROC's pgxactoff field should
be sufficient.
The comments on PROC_HDR and PGPROC also reference the deleted
PGPROC->pgxactoff field, so that also must be adjusted; there may be
several other places, as I didn't do a full check on the codebase.
Once the relevant comments are added and adjusted I think this is
ready for a committer.
Kind regards,
Matthias van de Meent
Databricks (https://www.databricks.com)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nazir Bilal Yavuz | 2026-07-17 08:57:18 | Re: ci: namespace ccache by PostgreSQL major version |
| Previous Message | Daniel Gustafsson | 2026-07-17 08:36:45 | Re: PGLZ Compression Optimization |