Re: tablecmds: reject CLUSTER ON for partitioned tables earlier

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: tablecmds: reject CLUSTER ON for partitioned tables earlier
Date: 2026-03-17 05:36:48
Message-ID: abjocHubZk6Ky4Xp@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 17, 2026 at 09:12:13AM +0800, Chao Li wrote:
> Anyway, I added the asserts in ATExecAddInherit() and
> ATExecDropInherit() in v9. If you have a second thought, I can tune
> it further.

I have removed the assertions at the end, after looking at the
surroundings for hints.

> PFA v9:
> * 0001 - added a NO INHERIT test case in typed_table.sql
> * 0002 - added asserts in ATExecAddInherit and ATExecDropInherit.

The comments rmeoved from ATPrepAddInherit() were still not at the
correct location. CreateInheritance() is the routine in charge of the
column and constraint checks.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2026-03-17 05:51:12 Re: Return pg_control from pg_backup_stop().
Previous Message Zsolt Parragi 2026-03-17 05:29:04 Re: Improve OAuth discovery logging