Re: tablecmds: reject CLUSTER ON for partitioned tables earlier

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: tablecmds: reject CLUSTER ON for partitioned tables earlier
Date: 2026-03-17 06:14:29
Message-ID: 3040CFCB-3EDE-4E3C-8044-58C0F2E52B93@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Mar 17, 2026, at 13:36, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Tue, Mar 17, 2026 at 09:12:13AM +0800, Chao Li wrote:
>> Anyway, I added the asserts in ATExecAddInherit() and
>> ATExecDropInherit() in v9. If you have a second thought, I can tune
>> it further.
>
> I have removed the assertions at the end, after looking at the
> surroundings for hints.
>
>> PFA v9:
>> * 0001 - added a NO INHERIT test case in typed_table.sql
>> * 0002 - added asserts in ATExecAddInherit and ATExecDropInherit.
>
> The comments rmeoved from ATPrepAddInherit() were still not at the
> correct location. CreateInheritance() is the routine in charge of the
> column and constraint checks.
> --
> Michael

Hi Michael, thank you very much for fixing the comment and pushing the patch.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message yangboyu 2026-03-17 06:17:57 bogus pg_init_privs.initprivs in pg_upgrade
Previous Message shveta malik 2026-03-17 06:05:53 Re: [Proposal] Adding Log File Capability to pg_createsubscriber