| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | zhanghu <kongbaik228(at)gmail(dot)com> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add documentation for PG_ABS_SRCDIR, PG_ABS_BUILDDIR, PG_LIBDIR, PG_DLSUFFIX |
| Date: | 2026-03-11 21:34:51 |
| Message-ID: | abHf-9DCoJrsPqjX@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 11, 2026 at 11:10:44AM +0800, zhanghu wrote:
> The doc changes look good overall. I applied the patch locally and rendered
> the documentation to HTML, the new page also looks good.
>
> A few minor nitpicks:
>
> + <para>
> + Name of extension for dynamically-loadable modules (e.g.
> + <literal>.so</literal> on Linux).
> + </para>
>
> I think we need a "the" before "dynamically-loadable".
Don't think this one's necessary here, actually, as it refers to a
general concept around modules.
> + These are useful when dealing with function and object loading
> + that require specific paths to work, like paths defined in a
> + <command>CREATE FUNCTION</command> or <command>LOAD</command>
> + command, for example.
>
> The ending "for example" sounds redundant, since "like" already conveys the
> meaning of "for example".
WFM.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2026-03-11 21:39:04 | Re: [PATCH v1] command_tag_format — protocol-level command tag negotiation via _pq_ |
| Previous Message | Michael Paquier | 2026-03-11 21:33:08 | Re: Streamify more code paths |