Re: Add documentation for PG_ABS_SRCDIR, PG_ABS_BUILDDIR, PG_LIBDIR, PG_DLSUFFIX

From: zhanghu <kongbaik228(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add documentation for PG_ABS_SRCDIR, PG_ABS_BUILDDIR, PG_LIBDIR, PG_DLSUFFIX
Date: 2026-03-11 03:10:44
Message-ID: CAB5m2Qt_jQ2UJNainsp+jhzjRS6rCPd5ti1MBwDoJnXXG2v_Vg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(at)paquier(dot)xyz> 于2026年3月11日周三 09:07写道:

>
> Hi all,
>
> d1029bb5a26c has switched the in-core tests suited based on pg_regress
> to do path substitutions based on the set of environment variables
> listed in $subject, rather than replacements based on input and output
> files, generating new files.
>
> These can be really useful for extension developers who maintain SQL
> test suites, so how about documenting them?
>
> I'd like to propose the attached patch, for HEAD, so as one does not
> need to guess their existence from the SQL files or pg_regress.c.
>
> Thoughts or comments?
> --
> Michael

Hi

The doc changes look good overall. I applied the patch locally and rendered
the documentation to HTML, the new page also looks good.

A few minor nitpicks:

+ <para>
+ Name of extension for dynamically-loadable modules (e.g.
+ <literal>.so</literal> on Linux).
+ </para>

I think we need a "the" before "dynamically-loadable".

+ These are useful when dealing with function and object loading
+ that require specific paths to work, like paths defined in a
+ <command>CREATE FUNCTION</command> or <command>LOAD</command>
+ command, for example.

The ending "for example" sounds redundant, since "like" already conveys the
meaning of "for example".

Best regards,
Zhang Hu

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message shveta malik 2026-03-11 03:24:46 Re: Skipping schema changes in publication
Previous Message Shinya Kato 2026-03-11 02:38:23 Re: pg_stat_replication.*_lag sometimes shows NULL during active replication