Makes sense to me. The per-thread path already had a good filename, but was missing the file extension, so more benefits than just consistency.
On Wed, Jul 22, 2026, at 3:50 PM, Magnus Hagander wrote:
>
>
> On Thu, 25 Jun 2026 at 16:13, Kevin <me(at)kevinrocker(dot)com> wrote:
>> __
>> The mailing list monthly archives were all downloading with the same filename, just "psql-hackers.mbox", which turned into "psql-hackers(1).mbox", "psql-hackers(2).mbox", etc.
>>
>> This patch sets the `Content-Disposition` header to a filename that includes the list and the year/month.
>
> I like this idea and the patch looks good. However, is there a reason not to also do this for the other code path calling _build_mbox()? If nothing else, for consistency?
>
> --
> Magnus Hagander
> Me: https://www.hagander.net/
> Work: https://www.redpill-linpro.com/