| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Kevin Rocker <me(at)kevinrocker(dot)com> |
| Cc: | pgsql-www(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] Disambiguate mbox download files |
| Date: | 2026-08-29 07:58:14 |
| Message-ID: | CABUevEz1_iACkDZpUF6NozYdFq9HiKvO2T_Ugs1BTk7v9LD4MA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-www |
Hi!
Looks good! Applied and pushed, thanks!
//Magnus
On Fri, 31 Jul 2026 at 16:52, Kevin Rocker <me(at)kevinrocker(dot)com> wrote:
> Makes sense to me. The per-thread path already had a good filename, but
> was missing the file extension, so more benefits than just consistency.
>
> On Wed, Jul 22, 2026, at 3:50 PM, Magnus Hagander wrote:
>
>
>
> On Thu, 25 Jun 2026 at 16:13, Kevin <me(at)kevinrocker(dot)com> wrote:
>
>
> The mailing list monthly archives were all downloading with the same
> filename, just "psql-hackers.mbox", which turned into
> "psql-hackers(1).mbox", "psql-hackers(2).mbox", etc.
>
> This patch sets the `Content-Disposition` header to a filename that
> includes the list and the year/month.
>
>
> I like this idea and the patch looks good. However, is there a reason not
> to also do this for the other code path calling _build_mbox()? If nothing
> else, for consistency?
>
> --
> Magnus Hagander
> Me: https://www.hagander.net/ <http://www.hagander.net/>
> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
>
>
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tristan Partin | 2026-08-31 20:23:55 | Re: Python Tooling |
| Previous Message | Joe Conway | 2026-08-28 12:17:27 | Re: Add Masahiko S to security page |