| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Mark Wong <markwkm(at)gmail(dot)com> |
| Subject: | Re: pgsql: Change default value of default_toast_compression to "lz4", when |
| Date: | 2026-03-04 22:51:26 |
| Message-ID: | aai3bl7CbkSpjz0H@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Thu, Mar 05, 2026 at 07:47:03AM +0900, Michael Paquier wrote:
> Hmm. If you guys feel strongly about it, I'd be OK to revert. Now
> there is a way to split the pie into two halves: we can still
> introduce DEFAULT_TOAST_COMPRESSION and use lz4 as default for the GUC
> if lz4 is included in the build but, leave the switch of --with-lz4 to
> --without-lz4 out of the equation. This choice would leave the
> buildfarm in piece, and it still achieves the goal of enabling LZ4 in
> TOAST by default, as long as --without-lz4 is used. As long as the
> latter is achieved, the point of the change would be made.
As I had the idea to press send too quickly, here's a reformulated
version. ;)
We can still introduce DEFAULT_TOAST_COMPRESSION and use lz4 as
default for the GUC if lz4 is included in the build but leave the
switch of --with-lz4 to --without-lz4 out of the equation. This
choice would leave the buildfarm in peace, and it still achieves the
goal of enabling LZ4 in TOAST by default, as long as --with-lz4 is
used. As long as the latter goal is achieved, the point of the change
would be made, at least partially.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-03-04 23:22:30 | Re: pgsql: Change default value of default_toast_compression to "lz4", when |
| Previous Message | Michael Paquier | 2026-03-04 22:47:03 | Re: pgsql: Change default value of default_toast_compression to "lz4", when |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sami Imseih | 2026-03-04 22:54:21 | Re: Add starelid, attnum to pg_stats and leverage this in pg_dump |
| Previous Message | Michael Paquier | 2026-03-04 22:47:03 | Re: pgsql: Change default value of default_toast_compression to "lz4", when |