Re: pgsql: Change default value of default_toast_compression to "lz4", when

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Mark Wong <markwkm(at)gmail(dot)com>
Subject: Re: pgsql: Change default value of default_toast_compression to "lz4", when
Date: 2026-03-04 22:47:03
Message-ID: aai2Z0UQkkHqvSuQ@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Wed, Mar 04, 2026 at 05:34:49PM -0500, Tom Lane wrote:
> By my count, two-thirds of the buildfarm is broken. (100 failing
> animals, 56 working ones have reported since this commit.)
>
> We would not normally tolerate leaving things that way for any
> great length of time, and I don't think this commit should get
> a pass. I think it needs to be reverted until a very much
> larger fraction of buildfarm owners have prepared for it.

Hmm. If you guys feel strongly about it, I'd be OK to revert. Now
there is a way to split the pie into two halves: we can still
introduce DEFAULT_TOAST_COMPRESSION and use lz4 as default for the GUC
if lz4 is included in the build but, leave the switch of --with-lz4 to
--without-lz4 out of the equation. This choice would leave the
buildfarm in piece, and it still achieves the goal of enabling LZ4 in
TOAST by default, as long as --without-lz4 is used. As long as the
latter is achieved, the point of the change would be made.

Opinions?
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2026-03-04 22:51:26 Re: pgsql: Change default value of default_toast_compression to "lz4", when
Previous Message Michael Paquier 2026-03-04 22:41:29 Re: pgsql: Change default value of default_toast_compression to "lz4", when

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2026-03-04 22:51:26 Re: pgsql: Change default value of default_toast_compression to "lz4", when
Previous Message Michael Paquier 2026-03-04 22:41:29 Re: pgsql: Change default value of default_toast_compression to "lz4", when