Re: Re: [COMMITTERS] pgsql: Use MINVALUE/MAXVALUE instead of UNBOUNDED for range partition b

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Use MINVALUE/MAXVALUE instead of UNBOUNDED for range partition b
Date: 2017-09-13 09:05:30
Message-ID: aac89c8d-0128-17bf-6ea1-5d0d187d8983@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Hi Dean,

On 2017/09/13 17:51, Dean Rasheed wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Tue, Sep 12, 2017 at 9:58 AM, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>>> Did anything happen on this, or did we just forget it completely?
>>
>> I forgot it. :-(
>>
>> I really think we should fix this.
>
> Ah, sorry. This was for me to follow up, and I dropped the ball.
>
> Here's a patch restoring the original error checks (actually not the
> same coding as used in previous versions of the patch, because that
> would have allowed a MINVALUE after a MAXVALUE and vice versa).
>
> A drawback to doing this is that we lose compatibility with syntaxes
> supported by other databases, which was part of the reason for
> choosing the terms MINVALUE and MAXVALUE in the first place.
>
> So thinking about this afresh, my preference would actually be to just
> canonicalise the values stored rather than erroring out.
>
> Thoughts?

Coincidentally, I just wrote the patch for canonicalizing stored values,
instead of erroring out. Please see attached if that's what you were
thinking too.

Thanks,
Amit

Attachment Content-Type Size
0001-Canonicalize-catalog-representation-of-range-partiti.patch text/plain 8.7 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2017-09-13 12:22:51 pgsql: Define LDAP_NO_ATTRS if necessary.
Previous Message Dean Rasheed 2017-09-13 08:51:12 Re: Re: [COMMITTERS] pgsql: Use MINVALUE/MAXVALUE instead of UNBOUNDED for range partition b

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2017-09-13 09:11:15 Re: Getting error message with latest PG source on Windows.
Previous Message Haribabu Kommi 2017-09-13 08:59:41 Re: utility commands benefiting from parallel plan