From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Re: [COMMITTERS] pgsql: Use MINVALUE/MAXVALUE instead of UNBOUNDED for range partition b |
Date: | 2017-09-13 08:51:12 |
Message-ID: | CAEZATCX4rjpTwPJM7WmDR9ULaounNuN_bpw3A_VOhYUuMqTkTg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Tue, Sep 12, 2017 at 9:58 AM, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>> Did anything happen on this, or did we just forget it completely?
>
> I forgot it. :-(
>
> I really think we should fix this.
Ah, sorry. This was for me to follow up, and I dropped the ball.
Here's a patch restoring the original error checks (actually not the
same coding as used in previous versions of the patch, because that
would have allowed a MINVALUE after a MAXVALUE and vice versa).
A drawback to doing this is that we lose compatibility with syntaxes
supported by other databases, which was part of the reason for
choosing the terms MINVALUE and MAXVALUE in the first place.
So thinking about this afresh, my preference would actually be to just
canonicalise the values stored rather than erroring out.
Thoughts?
Regards,
Dean
Attachment | Content-Type | Size |
---|---|---|
restore-minvalue-maxvalue-error-checks.patch | application/octet-stream | 22.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Langote | 2017-09-13 09:05:30 | Re: Re: [COMMITTERS] pgsql: Use MINVALUE/MAXVALUE instead of UNBOUNDED for range partition b |
Previous Message | Tom Lane | 2017-09-12 23:28:36 | pgsql: Add psql variables to track success/failure of SQL queries. |
From | Date | Subject | |
---|---|---|---|
Next Message | Victor Drobny | 2017-09-13 08:57:20 | Re: new function for tsquery creartion |
Previous Message | Kyotaro HORIGUCHI | 2017-09-13 08:42:39 | Re: WAL logging problem in 9.4.3? |