Re: enable pg_stat_statements to track rows processed by REFRESH MATERIALIZED VIEW

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: Yuki Seino <seinoyu(at)oss(dot)nttdata(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: enable pg_stat_statements to track rows processed by REFRESH MATERIALIZED VIEW
Date: 2020-11-02 11:01:40
Message-ID: aab41011-887e-6cae-ba1f-d47b56412b88@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020/11/02 14:02, Yuki Seino wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: tested, passed
> Documentation: tested, passed
>
> +1.
> I checked the patch and there were no problems.

+ PG_END_TRY();
+ SetQueryCompletion(qc, CMDTAG_REFRESH_MATERIALIZED_VIEW, processed);

Isn't it better to call SetQueryCompletion() in ExecRefreshMatView()
instead of ProcessUtilitySlow() (e.g., ExecCreateTableAs() does)?

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2020-11-02 11:19:03 Re: Split copy.c
Previous Message Heikki Linnakangas 2020-11-02 10:57:58 Re: [patch] [doc] Add SELECT clause literals to queries section headers