| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Erik Rijkers <er(at)xs4all(dot)nl> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com> |
| Subject: | Re: Split copy.c |
| Date: | 2020-11-02 11:19:03 |
| Message-ID: | 14f9f8b7-c123-a6b6-b6ec-d55928cf0052@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 02/11/2020 11:36, Erik Rijkers wrote:
> On 2020-11-02 10:03, Heikki Linnakangas wrote:
>> While looking at the parallel copy patches, it started to annoy me how
>> large copy.c is. It confuses my little head. (Ok, it's annoyed me many
>> times in the past, but I haven't done anything about it.)
>
>> [0001-Split-copy.c-into-...o.c-and-copyfrom.c.patch]
>
> There seems to be an oversight of contrib/file_fdw. (debian 10, gcc
> 8.3.0)
Ah yeah, I missed updating file_fdw. Here's a new patch.
- Heikki
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Split-copy.c-into-copyto.c-and-copyfrom.c.patch | text/x-patch | 276.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ranier Vilela | 2020-11-02 11:25:27 | Re: Explicit NULL dereference (src/backend/utils/adt/ruleutils.c) |
| Previous Message | Fujii Masao | 2020-11-02 11:01:40 | Re: enable pg_stat_statements to track rows processed by REFRESH MATERIALIZED VIEW |