Re: pg_resetwal.c: duplicate '0' in hex character set for -l option validation

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: jinbinge <jinbinge(at)126(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_resetwal.c: duplicate '0' in hex character set for -l option validation
Date: 2026-03-02 02:24:52
Message-ID: aaT09KfuMqMcLakl@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Mar 02, 2026 at 10:13:38AM +0800, jinbinge wrote:
> "0123456789ABCDEFabcdef". This change would be purely cosmetic with
> no behavioral impact, but would eliminate the unnecessary
> duplication.

That's entirely cosmetic, well why not.. There is also a
01234567890ABCDEF in src/bin/pg_upgrade/controldata.c. Perhaps we
could sanitize the whole as of 0123456789ABCDEF, which is larger in
trend compared to 1234567890ABCDEF when it comes to the C code, not
the tests.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Sami Imseih 2026-03-02 02:34:13 Re: Fix bug in multixact Oldest*MXactId initialization and access
Previous Message Michael Paquier 2026-03-02 02:15:36 Re: Defects with invalid stats data for expressions in extended stats