Re: Fix bug in multixact Oldest*MXactId initialization and access

From: Sami Imseih <samimseih(at)gmail(dot)com>
To: Yura Sokolov <y(dot)sokolov(at)postgrespro(dot)ru>
Cc: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Subject: Re: Fix bug in multixact Oldest*MXactId initialization and access
Date: 2026-03-02 02:34:13
Message-ID: CAA5RZ0umyHiQNwr1m6FVF0WPCP3QAFAzdF=mQ+_u-vknhOBYWw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> New version attached.

The comment here:

+static inline MultiXactId *
+PreparedXactOldestMemberMXactIdSlot(ProcNumber procno)
+{
+ /*
+ * The entries with indexes >= MaxBackends in the OldestMemberMXactId
+ * array are reserved for regular backends.

should say "array are reserved for prepared transactions"

otherwise, LGTM.

--
Sami Imseih
Amazon Web Services (AWS)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2026-03-02 02:35:02 Re: typo in alter_table.sgml (was: Re: pgsql: Allow ALTER COLUMN SET EXPRESSION on virtual columns with CHECK)
Previous Message Michael Paquier 2026-03-02 02:24:52 Re: pg_resetwal.c: duplicate '0' in hex character set for -l option validation