Re: change default default_toast_compression to lz4?

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: Euler Taveira <euler(at)eulerto(dot)com>, Aleksander Alekseev <aleksander(at)tigerdata(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: change default default_toast_compression to lz4?
Date: 2026-02-27 01:10:20
Message-ID: aaDu_Oa2yq19TAoF@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Feb 24, 2026 at 10:52:39PM +0100, Peter Eisentraut wrote:
> Your patch is adding documentation for the configure option --without-lz4,
> but you are leaving the documentation for --with-lz4 in place. You should
> delete the latter.

Ah, right. This is what we have done for ICU in fcb21b3acdcb. While
--with-lz4 is still allowed for backward-compatibility, we show only
--without-icu in the output of configure --help. Reflecting the
documentation to show up the same contents as --help makes sense.

Could you update the patch, Euler? This includes the blip in
meson.build regarding the addition of not_found_dep not really
required.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2026-02-27 01:12:43 Re: Improve checks for GUC recovery_target_xid
Previous Message Michael Paquier 2026-02-27 00:53:58 Defects with invalid stats data for expressions in extended stats