| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Euler Taveira <euler(at)eulerto(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Aleksander Alekseev <aleksander(at)tigerdata(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: change default default_toast_compression to lz4? |
| Date: | 2026-02-24 21:52:39 |
| Message-ID: | 7267cdf8-f270-4cb1-9713-43c92cffe179@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 19.02.26 17:12, Euler Taveira wrote:
> On Thu, Dec 4, 2025, at 11:23 PM, Michael Paquier wrote:
>>
>> So this had better be adjusted in one go, in the shape of a tweak in
>> mingw_cross_warning_script with the addition of a --without-lz4, same
>> way as for ICU.
>>
> Done.
>
>> Hmm. It seems to me that we should just set not_found_dep if lz4
>> cannot be found, leaving meson_options.txt as it is currently, no?
>>
> Done.
>
> Changes from last version:
>
> - adjust CI
> - set not_found_dep instead of warning message
> - remove quotes from default_toast_compression value
>
> It is aligned with ICU and readline behavior.
Your patch is adding documentation for the configure option
--without-lz4, but you are leaving the documentation for --with-lz4 in
place. You should delete the latter.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2026-02-24 21:54:52 | Re: change default default_toast_compression to lz4? |
| Previous Message | Tom Lane | 2026-02-24 21:51:43 | Re: Cleaning up array_ref() and array_set() |