Re: Fix wrong log in pgstat_report_checksum_failures_in_db()

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: wangpeng <215722532(at)qq(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Fix wrong log in pgstat_report_checksum_failures_in_db()
Date: 2026-02-11 11:06:32
Message-ID: aYxiuJWyXZmnab4T@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Feb 11, 2026 at 05:22:27PM +0800, wangpeng wrote:
> The function pgstat_report_checksum_failures_in_db(), file
> pgstat_database.c,
> currently emits a log message referring to "conflicts", which seems wrong.
> As the function name suggesting, the log message should refer to "checksum
> failures".

Right, that's strange. It looks like a copy-pasto, but I am not sure
from where.

> - elog(WARNING, "could not report %d conflicts for DB %u",
> + elog(WARNING, "could not report %d checksum failures for DB %u",
> failurecount, dboid);

We may as well use "for database" here. Let's improve it a bit more
while on it, even if it is not translated.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Gilles Darold 2026-02-11 11:32:01 Re: Pasword expiration warning
Previous Message Bertrand Drouvot 2026-02-11 10:58:41 Re: PGPROC alignment (was Re: pgsql: Separate RecoveryConflictReasons from procsignals)