Re: Remove "struct" markers from varlena, varatt_external and varatt_indirect

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove "struct" markers from varlena, varatt_external and varatt_indirect
Date: 2026-02-10 22:36:16
Message-ID: aYuy4JV86GvWzCS5@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Feb 10, 2026 at 10:29:05AM -0500, Tom Lane wrote:
> -typedef struct varlena
> +typedef struct
>
> It still compiles, proving that you found all the usages.
> (I am *not* suggesting that you do that in the committed patch;
> it'd break extensions to little purpose.)

I didn't consider doing that to cross-check the change. That's a good
one.

Applied that now, thanks all for the reviews.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2026-02-10 22:39:20 Do we still need MULE_INTERNAL?
Previous Message Tom Lane 2026-02-10 22:23:03 Re: Decoupling our alignment assumptions about int64 and double