Michael Paquier <michael(at)paquier(dot)xyz> writes:
> This patch has been sitting on my desk for a couple of weeks now, and
> I am playing with varatt.h. Any objections in getting rid of these
> struct markers at the end as of the patch posted upthread?
+1 for concept. Also, I did a bit of quick mechanical review
and found no problems:
1. I tried removing these struct tags altogether, ie
-typedef struct varlena
+typedef struct
It still compiles, proving that you found all the usages.
(I am *not* suggesting that you do that in the committed patch;
it'd break extensions to little purpose.)
2. I checked that pgindent is happy.
Looks ready to go to me, except the commit message needs work.
regards, tom lane