| From: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Separate RecoveryConflictReasons from procsignals |
| Date: | 2026-02-10 15:19:09 |
| Message-ID: | aYtMbb28qxqLrhvC@ip-10-97-1-34.eu-west-3.compute.internal |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Hi,
On Tue, Feb 10, 2026 at 02:32:37PM +0000, Heikki Linnakangas wrote:
> Separate RecoveryConflictReasons from procsignals
>
> Share the same PROCSIG_RECOVERY_CONFLICT flag for all recovery
> conflict reasons. To distinguish, have a bitmask in PGPROC to indicate
> the reason(s).
I did not look at the thread, so sorry to be late, but that makes the size of PGPROC
going from 832 to 840 bytes, so not a multiple of 64 anymore. Is that something
to worry about? (same kind of discussion in [1]).
[1]: https://postgr.es/m/tw53roer2j4quxh7vlyv62drc5fo6c6zdltvl6d2dttqa62uhi%40stwlpdwlftpj
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2026-02-10 15:52:16 | Re: pgsql: Separate RecoveryConflictReasons from procsignals |
| Previous Message | Heikki Linnakangas | 2026-02-10 14:32:37 | pgsql: Refactor ProcessRecoveryConflictInterrupt for readability |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2026-02-10 15:21:15 | Re: Changing shared_buffers without restart |
| Previous Message | Tatsuya Kawata | 2026-02-10 15:18:26 | Re: [PATCH] Add sampling statistics to autoanalyze log output |