pgsql: Separate RecoveryConflictReasons from procsignals

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Separate RecoveryConflictReasons from procsignals
Date: 2026-02-10 14:32:37
Message-ID: E1vpon6-002LVp-2z@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Separate RecoveryConflictReasons from procsignals

Share the same PROCSIG_RECOVERY_CONFLICT flag for all recovery
conflict reasons. To distinguish, have a bitmask in PGPROC to indicate
the reason(s).

Reviewed-by: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Discussion: https://www.postgresql.org/message-id/4cc13ba1-4248-4884-b6ba-4805349e7f39@iki.fi

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/17f51ea818753093f929b4c235f3b89ebcc7c5fb

Modified Files
--------------
src/backend/commands/dbcommands.c | 1 +
src/backend/commands/tablespace.c | 1 +
src/backend/replication/logical/logicalctl.c | 1 +
src/backend/replication/slot.c | 6 +-
src/backend/storage/buffer/bufmgr.c | 5 +-
src/backend/storage/ipc/procarray.c | 136 ++++++++++++++++++---------
src/backend/storage/ipc/procsignal.c | 22 +----
src/backend/storage/ipc/standby.c | 61 ++++++------
src/backend/storage/lmgr/proc.c | 5 +-
src/backend/tcop/postgres.c | 117 ++++++++++++-----------
src/backend/utils/activity/pgstat_database.c | 18 ++--
src/backend/utils/adt/mcxtfuncs.c | 1 +
src/include/storage/proc.h | 10 ++
src/include/storage/procarray.h | 7 +-
src/include/storage/procsignal.h | 16 +---
src/include/storage/standby.h | 34 ++++++-
src/include/tcop/tcopprot.h | 2 +-
src/tools/pgindent/typedefs.list | 1 +
18 files changed, 258 insertions(+), 186 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bertrand Drouvot 2026-02-10 15:19:09 Re: pgsql: Separate RecoveryConflictReasons from procsignals
Previous Message Michael Paquier 2026-02-10 07:59:31 pgsql: Simplify some log messages in extended_stats_funcs.c

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2026-02-10 14:32:54 Re: Refactor recovery conflict signaling a little
Previous Message Bertrand Drouvot 2026-02-10 13:38:15 Re: Report bytes and transactions actually sent downtream