| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | John Naylor <johncnaylorls(at)gmail(dot)com> |
| Cc: | Greg Burd <greg(at)burd(dot)me>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: refactor architecture-specific popcount code |
| Date: | 2026-02-06 16:12:57 |
| Message-ID: | aYYTCSN0wzORkAgc@nathan |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Feb 05, 2026 at 02:48:44PM +0700, John Naylor wrote:
> On Thu, Feb 5, 2026 at 4:43 AM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>> Sure. I'm tempted to suggest that we only use the plain C version here,
>> too. The SSE4.2 bms_num_members() test I did yesterday used it and showed
>> improvement at one word. If we do that, we can rip out even more code
>> since we no longer need the popcount built-ins.
>
> Unlike the 32-bit case, people do run production on 64-bit platforms
> that are not Arm/x86, so that would require effort to see if the
> builtins are worth it for them. That seems like a separate effort. I
> can help with that, but let's get the tested stuff in first.
Alright. I moved that to a new 0004 patch that we can consider separately
once 0001-0003 have been committed.
--
nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v11-0001-Remove-some-unnecessary-optimizations-in-popcoun.patch | text/plain | 6.9 KB |
| v11-0002-Remove-specialized-word-length-popcount-implemen.patch | text/plain | 11.5 KB |
| v11-0003-Make-use-of-pg_popcount-in-more-places.patch | text/plain | 3.0 KB |
| v11-0004-Remove-uses-of-popcount-builtins.patch | text/plain | 4.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Antonin Houska | 2026-02-06 16:29:58 | Re: Adding REPACK [concurrently] |
| Previous Message | Jim Jones | 2026-02-06 16:05:02 | Re: Add CREATE SCHEMA ... LIKE support |