| From: | John Naylor <johncnaylorls(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Greg Burd <greg(at)burd(dot)me>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: refactor architecture-specific popcount code |
| Date: | 2026-02-05 07:48:44 |
| Message-ID: | CANWCAZa3BRPossmbAQoPb1zdQ7iq9TnUvZhqpmt4AQKhdPocxg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Feb 5, 2026 at 4:43 AM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
> Sure. I'm tempted to suggest that we only use the plain C version here,
> too. The SSE4.2 bms_num_members() test I did yesterday used it and showed
> improvement at one word. If we do that, we can rip out even more code
> since we no longer need the popcount built-ins.
Unlike the 32-bit case, people do run production on 64-bit platforms
that are not Arm/x86, so that would require effort to see if the
builtins are worth it for them. That seems like a separate effort. I
can help with that, but let's get the tested stuff in first.
> * tests plain C version on an Apple M3 *
>
> Yeah, the plain C version might be marginally slower than the built-in
> version for that test, but it still seems quite a bit faster than HEAD.
>
> HEAD v8 v10
> 40 25 29
That's good to know, and maybe it'll be true elsewhere.
--
John Naylor
Amazon Web Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhijie Hou (Fujitsu) | 2026-02-05 08:12:33 | RE: Warn when creating or enabling a subscription with max_logical_replication_workers = 0 |
| Previous Message | Peter Smith | 2026-02-05 07:46:58 | Re: Warn when creating or enabling a subscription with max_logical_replication_workers = 0 |