Re: Remove unused isCommit parameter from AtEOXact_LocalBuffers

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, zengman <zengman(at)halodbtech(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Remove unused isCommit parameter from AtEOXact_LocalBuffers
Date: 2026-02-04 00:37:52
Message-ID: aYKU4AHnabERcy1j@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Feb 03, 2026 at 09:34:33AM -0600, Nathan Bossart wrote:
> On Tue, Feb 03, 2026 at 09:45:49AM -0500, Tom Lane wrote:
>> I think we should reject this as useless code churn. The parameter
>> was needed in the past and might be needed again in the future.
>> It's fairly common for other AtEOXact functions to take an isCommit
>> flag, so I don't find it surprising for these to have one.
>
> +1

+1. Symmetry is usually relevant in the signature of these cleanup
functions.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2026-02-04 00:41:07 Re: pg_upgrade: optimize replication slot caught-up check
Previous Message Peter Smith 2026-02-04 00:14:53 Use allocation macros in the logical replication code