Re: Remove unused isCommit parameter from AtEOXact_LocalBuffers

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: zengman <zengman(at)halodbtech(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Remove unused isCommit parameter from AtEOXact_LocalBuffers
Date: 2026-02-03 15:34:33
Message-ID: aYIViZ-zoeH3OIy-@nathan
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Feb 03, 2026 at 09:45:49AM -0500, Tom Lane wrote:
> I think we should reject this as useless code churn. The parameter
> was needed in the past and might be needed again in the future.
> It's fairly common for other AtEOXact functions to take an isCommit
> flag, so I don't find it surprising for these to have one.

+1

--
nathan

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Lukas Fittl 2026-02-03 15:44:14 Re: Non-deterministic buffer counts reported in execution with EXPLAIN ANALYZE BUFFERS
Previous Message Nathan Bossart 2026-02-03 15:28:49 Re: Pasword expiration warning