Re: recovery.signal not cleaned up when both signal files are present

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: David Steele <david(at)pgbackrest(dot)org>, Nikolay Samokhvalov <nik(at)postgres(dot)ai>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: recovery.signal not cleaned up when both signal files are present
Date: 2026-02-13 06:18:44
Message-ID: aY7CRKjTINP80aUm@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Feb 13, 2026 at 03:05:45PM +0900, Fujii Masao wrote:
> Yeah, so I've added the test as suggested. The updated patch is attached.

What's the point in having the check for the files in data_dir? The
second one for standby2 should be enough as this is to test only
readRecoverySignalFile().

Except for this nit, that's OK by me.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bertrand Drouvot 2026-02-13 06:42:42 Re: Replace literal 0 values with the appropriate Invalid* constants
Previous Message Ashutosh Sharma 2026-02-13 06:08:55 Re: [PATCH] Support automatic sequence replication