| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | David Steele <david(at)pgbackrest(dot)org> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Nikolay Samokhvalov <nik(at)postgres(dot)ai>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: recovery.signal not cleaned up when both signal files are present |
| Date: | 2026-02-13 06:05:45 |
| Message-ID: | CAHGQGwFrj5Qxizj48TR3=mqs0Lsmb72Q=zB_wMKSks+K15_e4w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Feb 13, 2026 at 9:55 AM David Steele <david(at)pgbackrest(dot)org> wrote:
>
> On 2/10/26 11:52, Michael Paquier wrote:
> > On Tue, Feb 10, 2026 at 12:26:36PM +0900, Fujii Masao wrote:
> >> +1 to apply this change only to the master branch. Patch attached.
> >
> > It looks like something we should have a test for, at least..
>
> +1 for a test.
Yeah, so I've added the test as suggested. The updated patch is attached.
> > + /*
> > + *
> > + * If both signal files are present, standby signal file takes precedence.
> > + * If neither is present then we won't enter archive recovery.
> > + */
> >
> > This comment's format is incorrect.
>
> Other than the comment the patch looks good overall.
Fixed. Thanks all for the review!
Regards,
--
Fujii Masao
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Remove-recovery.signal-at-recovery-end-when-both-.patch | application/octet-stream | 4.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Sharma | 2026-02-13 06:08:55 | Re: [PATCH] Support automatic sequence replication |
| Previous Message | Andreas Karlsson | 2026-02-13 05:56:00 | Re: Incremental View Maintenance, take 2 |