| From: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Tomas Vondra <tomas(at)vondra(dot)me>, Christoph Berg <myon(at)debian(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Introduce pg_shmem_allocations_numa view |
| Date: | 2026-02-12 17:23:49 |
| Message-ID: | aY4MpVrK++9oXvti@ip-10-97-1-34.eu-west-3.compute.internal |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Hi,
On Thu, Feb 12, 2026 at 05:43:47PM +0100, Álvaro Herrera wrote:
> On 2026-Feb-12, Heikki Linnakangas wrote:
>
> > I just noticed that this (commit bf1119d74a: Add CHECK_FOR_INTERRUPTS into
> > pg_numa_query_pages) made the function unusable in frontend programs,
> > because CHECK_FOR_INTERRUPTS is server only.
Good catch! Out of curiosity how did you find the issue? Were you building a
client tool making used of pg_numa_query_pages()?
> It's not used in frontend
> > programs today, but it was placed in src/port/ with the idea that it could
> > be.
>
> Your patch LGTM.
+1
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2026-02-12 17:34:25 | pgsql: Remove specialized word-length popcount implementations. |
| Previous Message | Álvaro Herrera | 2026-02-12 16:43:47 | Re: pgsql: Introduce pg_shmem_allocations_numa view |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2026-02-12 17:34:38 | Re: refactor architecture-specific popcount code |
| Previous Message | Andres Freund | 2026-02-12 17:12:03 | Re: Odd usage of errmsg_internal in bufmgr.c |