Re: pgsql: Introduce pg_shmem_allocations_numa view

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Cc: Tomas Vondra <tomas(at)vondra(dot)me>, Christoph Berg <myon(at)debian(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Introduce pg_shmem_allocations_numa view
Date: 2026-02-12 17:42:20
Message-ID: 0aac5d44-0063-458d-8792-e9bbbc37fe72@iki.fi
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 12/02/2026 19:23, Bertrand Drouvot wrote:
> Hi,
>
> On Thu, Feb 12, 2026 at 05:43:47PM +0100, Álvaro Herrera wrote:
>> On 2026-Feb-12, Heikki Linnakangas wrote:
>>
>>> I just noticed that this (commit bf1119d74a: Add CHECK_FOR_INTERRUPTS into
>>> pg_numa_query_pages) made the function unusable in frontend programs,
>>> because CHECK_FOR_INTERRUPTS is server only.
>
> Good catch! Out of curiosity how did you find the issue? Were you building a
> client tool making used of pg_numa_query_pages()?

I was working on my "interrupts vs signals" patch, which needed to
change some #includes in pg_numa.c, when I spotted that it already had
that issue.

>> It's not used in frontend
>>> programs today, but it was placed in src/port/ with the idea that it could
>>> be.
>>
>> Your patch LGTM.
>
> +1

Pushed, thanks!

- Heikki

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2026-02-12 19:04:39 Re: pgsql: Add file_extend_method=posix_fallocate,write_zeros.
Previous Message Heikki Linnakangas 2026-02-12 17:42:15 pgsql: Make pg_numa_query_pages() work in frontend programs

Browse pgsql-hackers by date

  From Date Subject
Next Message Álvaro Herrera 2026-02-12 17:53:34 Re: Odd usage of errmsg_internal in bufmgr.c
Previous Message Nathan Bossart 2026-02-12 17:34:38 Re: refactor architecture-specific popcount code