| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Nikhil Kumar Veldanda <veldanda(dot)nikhilkumar17(at)gmail(dot)com> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Some tests for TOAST, STORAGE MAIN/EXTENDED |
| Date: | 2026-01-25 00:46:51 |
| Message-ID: | aXVn-xg0bdPc0aGM@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 23, 2026 at 12:25:33AM -0800, Nikhil Kumar Veldanda wrote:
> The `SELECT count(*) FROM :reltoastname` assertion is a bit brittle
> for `STORAGE EXTENDED`: depending on the toast compression method /
> effectiveness, the value may end up as >1 chunk, which would flip the
> expected count(*) = 1. Prefer SELECT count(DISTINCT chunk_id) FROM
> :reltoastname (or WHERE chunk_seq = 0) and adjust expected.
Yeah, this suggestion sounds sensible and that would still notice what
I was able to break.
> pg_column_compression() expects pglz, but default_toast_compression
> isn’t pinned here. Suggest SET default_toast_compression = 'pglz';
> near this block; otherwise this can fail on builds with a different
> default.
Agreed, let's do that as well.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-01-25 00:54:36 | Re: Buffer locking is special (hints, checksums, AIO writes) |
| Previous Message | David E. Wheeler | 2026-01-24 23:49:01 | Re: ABI Compliance Checker GSoC Project |