Re: Some tests for TOAST, STORAGE MAIN/EXTENDED

From: Nikhil Kumar Veldanda <veldanda(dot)nikhilkumar17(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Some tests for TOAST, STORAGE MAIN/EXTENDED
Date: 2026-01-23 08:25:33
Message-ID: CAFAfj_Hq_rMqUKDyz573gZhjd8bEpBx5j4MLNJvZ9PnouJCxDg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Michael,

On Thu, Jan 22, 2026 at 11:04 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> Thoughts or comments?

Two nits on the new toasttest block:

The `SELECT count(*) FROM :reltoastname` assertion is a bit brittle
for `STORAGE EXTENDED`: depending on the toast compression method /
effectiveness, the value may end up as >1 chunk, which would flip the
expected count(*) = 1. Prefer SELECT count(DISTINCT chunk_id) FROM
:reltoastname (or WHERE chunk_seq = 0) and adjust expected.

pg_column_compression() expects pglz, but default_toast_compression
isn’t pinned here. Suggest SET default_toast_compression = 'pglz';
near this block; otherwise this can fail on builds with a different
default.

--
Nikhil Veldanda

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kai Wagner 2026-01-23 08:32:38 Re: Hackorum - a new mailing list frontend
Previous Message Anthonin Bonnefoy 2026-01-23 08:21:53 Re: Fix rounding method used to compute huge pages