Re: Add WALRCV_CONNECTING state to walreceiver

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Xuneng Zhou <xunengzhou(at)gmail(dot)com>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add WALRCV_CONNECTING state to walreceiver
Date: 2026-01-23 05:31:03
Message-ID: aXMHlwhEURdLB9-d@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jan 23, 2026 at 12:07:36PM +0800, Xuneng Zhou wrote:
> Thanks Michael — agreed. Patch v7 dropped the extra fast‑exit path and
> kept the change minimal: only switch to STREAMING if the state is
> still CONNECTING, otherwise leave it unchanged.

Thanks for the newer version of the patch. I have been playing with
it today, even before you have sent this v7, with a set of injection
points to make the WAL receiver wait at some of its steps, then
double-checked that the startup process was able to control the WAL
receiver as it should, flipping primary_conninfo with reloads. AFAIK
as I can see, that felt OK, so applied as a36164e7465f.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2026-01-23 05:43:21 Re: Skipping schema changes in publication
Previous Message Chao Li 2026-01-23 05:29:22 Re: More speedups for tuple deformation