Re: Add WALRCV_CONNECTING state to walreceiver

From: Xuneng Zhou <xunengzhou(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add WALRCV_CONNECTING state to walreceiver
Date: 2026-01-23 08:47:43
Message-ID: CABPTF7WQbywas2Fog8NP79xzLKSc8dvgVjSJfe_iPdmFRMy6pA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Fri, Jan 23, 2026 at 1:31 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Fri, Jan 23, 2026 at 12:07:36PM +0800, Xuneng Zhou wrote:
> > Thanks Michael — agreed. Patch v7 dropped the extra fast‑exit path and
> > kept the change minimal: only switch to STREAMING if the state is
> > still CONNECTING, otherwise leave it unchanged.
>
> Thanks for the newer version of the patch. I have been playing with
> it today, even before you have sent this v7, with a set of injection
> points to make the WAL receiver wait at some of its steps, then
> double-checked that the startup process was able to control the WAL
> receiver as it should, flipping primary_conninfo with reloads. AFAIK
> as I can see, that felt OK, so applied as a36164e7465f.
> --
> Michael

Thanks for checking and applying it. I’m playing with exposing
XLogRecoveryCtlData metrics at the SQL level, following your input.
I’ll post the patches and possibly start a new thread for discussion.

--
Best,
Xuneng

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2026-01-23 09:06:25 Re: Newly created replication slot may be invalidated by checkpoint
Previous Message Kai Wagner 2026-01-23 08:32:38 Re: Hackorum - a new mailing list frontend