| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Subject: | Re: Remove PG_MMAP_FLAGS |
| Date: | 2026-01-23 04:42:52 |
| Message-ID: | aXL8TKH2dvt7EgLO@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 23, 2026 at 08:04:18AM +0530, Ashutosh Bapat wrote:
> As Peter mentioned in the shared buffers resizing thread [1] it's
> placement and name in mem.h led us to think that it affects all mmap
> calls or that all mmap calls should use those flags. Neither of which
> is true. We have different mmap calls using different set of flags.
> Attached patch proposes changes similar (not exact) as you suggest
> above. Please take a look.
>
> [1] https://www.postgresql.org/message-id/12add41a-7625-4639-a394-a5563e349322@eisentraut.org
Okay, point taken. I can live with your patch suggestion based on
what you have attached.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2026-01-23 04:51:35 | Re: Assert the timestamp is available for ORIGN_DIFFERS conflicts |
| Previous Message | Hayato Kuroda (Fujitsu) | 2026-01-23 04:32:38 | RE: Assert the timestamp is available for ORIGN_DIFFERS conflicts |