Re: [PATCH] backup: Fix trivial typo and error message issues

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Aditya Gollamudi <adigollamudi(at)gmail(dot)com>
Cc: Steven Niu <niushiji(at)gmail(dot)com>, zengman <zengman(at)halodbtech(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] backup: Fix trivial typo and error message issues
Date: 2026-01-18 07:20:54
Message-ID: aWyJ1mfZ1mO_z9Pf@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jan 17, 2026 at 12:22:54PM -0800, Aditya Gollamudi wrote:
> Patch applies cleanly on current master and builds without issues!
>
> I ran make check successfully. I agree that endtli makes more sense here,
> and thanks for fixing the typo.

I am parking the typo for later. We had better backpatch the error
message part as it could lead to an incorrect analysis when should
AddWALInfoToBackupManifest() blurp. Will do that in a bit.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuo Ishii 2026-01-18 07:52:43 Re: Row pattern recognition
Previous Message Michael Paquier 2026-01-18 07:17:31 Re: [PATCH] Remove redundant Assert() calls in report_namespace_conflict()