Re: [PATCH] backup: Fix trivial typo and error message issues

On Thu, Jan 15, 2026 at 6:20 AM Steven Niu <niushiji(at)gmail(dot)com> wrote:

> From: zengman <zengman(at)halodbtech(dot)com>
> Sent: Thursday, January 15, 2026 21:02
> To: pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
> Subject: [PATCH] backup: Fix trivial typo and error message issues
>
>
> Hi all,
>
> I noticed two trivial issues in backup-related code:
> 1. backup_manifest.c: The timeline mismatch error message uses `starttli`
> instead of `endtli`.
> 2. basebackup_copy.c: There is a spelling error (sine → since) in the
> comment above the `PROGRESS_REPORT_BYTE_INTERVAL` macro.
>
> ```
> --- a/src/backend/backup/backup_manifest.c
> +++ b/src/backend/backup/backup_manifest.c
> @@ -253,7 +253,7 @@ AddWALInfoToBackupManifest(backup_manifest_info
> *manifest, XLogRecPtr startptr,
> if (first_wal_range && endtli != entry->tli)
> ereport(ERROR,
> errmsg("expected end timeline %u
> but found timeline %u",
> - starttli, entry->tli));
> + endtli, entry->tli));
> ```
>
> ```
> - * So we only check it after the number of bytes sine the last check
> reaches
> + * So we only check it after the number of bytes since the last check
> reaches
> ```
>
> --
> Regards,
> Man Zeng
> www.openhalo.org
>
>
> ________________________________________
>
> Nice catch! Agree that the expected end timeline should be endtli instead
> of starttli per the comments above the code.
>
> And the "sine" is obviously a typo.
>
> Regards,
> Steven

Patch applies cleanly on current master and builds without issues!

I ran make check successfully. I agree that endtli makes more sense here,
and thanks for fixing the typo.

Note: I wasn’t able to get make installcheck to run cleanly due to local
environment issues, which appear unrelated to this patch.

- Adi Gollamudi