Some cleanup of pg_stat_statements tests

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Some cleanup of pg_stat_statements tests
Date: 2026-01-19 23:33:49
Message-ID: aW6_Xc8auuu5iAPi@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all,

While looking at this area of the code, I have noticed that the new
"squashing" test is not consistent with the rest of the test suite,
re-creating the extension for nothing.

The structure of the test is to have the "cleanup" phase second to
last, so as there is no need to create multiple times the extensions.

In passing, I'd like to suggest that REGRESS in the Makefile uses one
item per line, to minimize diffs when we add new stuff.

Any thoughts or objections about the attached?
Thanks,
--
Michael

Attachment Content-Type Size
0001-pg_stat_statements-Clean-up-test-logic.patch text/x-diff 3.3 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuo Ishii 2026-01-19 23:33:53 Re: Row pattern recognition
Previous Message Michael Paquier 2026-01-19 23:23:38 Re: Extended Statistics set/restore/clear functions.