| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Some cleanup of pg_stat_statements tests |
| Date: | 2026-01-20 12:36:47 |
| Message-ID: | 202601201236.phfzenkxh4qi@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2026-Jan-20, Michael Paquier wrote:
> While looking at this area of the code, I have noticed that the new
> "squashing" test is not consistent with the rest of the test suite,
> re-creating the extension for nothing.
>
> The structure of the test is to have the "cleanup" phase second to
> last, so as there is no need to create multiple times the extensions.
Huh, yeah, agreed on this change.
> In passing, I'd like to suggest that REGRESS in the Makefile uses one
> item per line, to minimize diffs when we add new stuff.
Absolutely.
> Any thoughts or objections about the attached?
No objections here.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"Java is clearly an example of money oriented programming" (A. Stepanov)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hannu Krosing | 2026-01-20 12:48:44 | Re: Patch: dumping tables data in multiple chunks in pg_dump |
| Previous Message | Ajit Awekar | 2026-01-20 12:31:21 | Re: Periodic authorization expiration checks using GoAway message |