Re: [PATCH] Provide support for trailing commas

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Greg Sabino Mullane <htamfids(at)gmail(dot)com>
Subject: Re: [PATCH] Provide support for trailing commas
Date: 2026-01-08 15:03:22
Message-ID: aV_HOurziLsdyhuV@momjian.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jan 8, 2026 at 12:51:14AM -0500, Andres Freund wrote:
> Hi,
>
> On January 7, 2026 11:44:29 PM EST, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> >On Tue, Jan 6, 2026 at 03:35:38PM -0500, Greg Sabino Mullane wrote:
> >> tl;dr Provide support for trailing commas, where possible and practical.
> >>
> >> (Disclaimer: No LLM or AI was used to craft this patch or this email)
> >>
> >> Happy New Year! Please find attached a patch to provide comprehensive trailing
> >> comma support, where we allow (when possible) a comma that does NOT come before
> >> the next item in a list. To wit:
> >
> >I am unclear why you bothered to create and work on such a large email
> >and patch rather than ask if this was a desired change; see:
> >
> > https://wiki.postgresql.org/wiki/Todo#Development_Process
>
> Meh. This kind of change really needs information about the
> implementation cost to be judged. The process described there rarely is
> a good idea for anybody that has some community experience.

I disagree. It was clear in this case that it was the concept that was
not wanted, rather than the implementation cost.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

Do not let urgent matters crowd out time for investment in the future.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2026-01-08 15:24:23 Re: Fix typo in code comment
Previous Message Bryan Green 2026-01-08 14:57:54 Re: [PATCH] Fix severe performance regression with gettext 0.20+ on Windows