Re: [PATCH] Provide support for trailing commas

From: Andres Freund <andres(at)anarazel(dot)de>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Greg Sabino Mullane <htamfids(at)gmail(dot)com>
Subject: Re: [PATCH] Provide support for trailing commas
Date: 2026-01-08 15:39:41
Message-ID: 5ecvumscakju32sxnautb4dpqoz2vrbklko4kxg6f3zu7rx323@vtger6sdhl3r
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2026-01-08 10:03:22 -0500, Bruce Momjian wrote:
> On Thu, Jan 8, 2026 at 12:51:14AM -0500, Andres Freund wrote:
> > Hi,
> >
> > On January 7, 2026 11:44:29 PM EST, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > >On Tue, Jan 6, 2026 at 03:35:38PM -0500, Greg Sabino Mullane wrote:
> > >> tl;dr Provide support for trailing commas, where possible and practical.
> > >>
> > >> (Disclaimer: No LLM or AI was used to craft this patch or this email)
> > >>
> > >> Happy New Year! Please find attached a patch to provide comprehensive trailing
> > >> comma support, where we allow (when possible) a comma that does NOT come before
> > >> the next item in a list. To wit:
> > >
> > >I am unclear why you bothered to create and work on such a large email
> > >and patch rather than ask if this was a desired change; see:
> > >
> > > https://wiki.postgresql.org/wiki/Todo#Development_Process
> >
> > Meh. This kind of change really needs information about the
> > implementation cost to be judged. The process described there rarely is
> > a good idea for anybody that has some community experience.
>
> I disagree. It was clear in this case that it was the concept that was
> not wanted, rather than the implementation cost.

I don't agree with that, fwiw. I it were easy to implement, I think we ought
to allow trailing commas in many places, most importantly the select list and
from list.

Greetings,

Andres Freund

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jelte Fennema-Nio 2026-01-08 15:40:35 Re: [PATCH] Provide support for trailing commas
Previous Message Ashutosh Bapat 2026-01-08 15:32:01 Re: Fix typo in comment