Re: Fix for consume_xids advancing XIDs incorrectly

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Yushi Ogiwara <btogiwarayuushi(at)oss(dot)nttdata(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix for consume_xids advancing XIDs incorrectly
Date: 2026-01-08 01:41:42
Message-ID: aV8LVq8J7G1cxeAO@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Oct 31, 2024 at 11:53:34AM -0700, Masahiko Sawada wrote:
> I think it's better to just replace 2000 with 4000 and explain why
> 4000 is sufficient. Probably we can define '#define
> XID_SHORTCUT_THRESHOLD 4000" and put an assertion to XidSkip() or
> consume_xids_common() to check if the number of consumed XIDs doesn't
> exceed XID_SHORTCUT_THRESHOLD.

The patch has not been updated in some time, for what I am tracking is
still a bug. Sawada-san, Ogiwara-san does not seem to be around,
could it be possible for you to step in and fix the problems of this
thread? It's been more than one year since the last update on this
thread.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2026-01-08 01:46:33 Re: Refactor replication origin state reset helpers
Previous Message Japin Li 2026-01-08 01:40:37 Re: [PATCH] Add pg_get_role_ddl() functions for role recreation