| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Refactor replication origin state reset helpers |
| Date: | 2026-01-08 01:46:33 |
| Message-ID: | CAD21AoDo_JGZPooDmbXheJrCBbEHh_WTgi31B_qNXr3-=JV93A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 7, 2026 at 5:15 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
>
> On Wed, Jan 7, 2026 at 4:49 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>>
>>
>> <v5-0001-Refactor-replication-origin-state-reset-helpers.patch><v5-0002-Consolidate-replication-origin-session-globals-in.patch>
>>
>> The CF CI failed a test case, but I don’t think that’s mine. I just did a self-review for v5 and couldn’t find any logic change. So I would guess the CI failure was intermittent. I don’t know how to rerun the CI test other than bumping the patch version and re-posting.
>
>
> V6 is only a rebase, nothing new.
Thank you for updating the patches.
I've made some cosmetic changes to both patches (comments and the
commit messages). Please review them and let me know what you think.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0002-Consolidate-replication-origin-session-globals-in.patch | application/octet-stream | 22.4 KB |
| v7-0001-Refactor-replication-origin-state-reset-helpers.patch | application/octet-stream | 5.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Jackson | 2026-01-08 02:00:43 | Re: Proposal: Add a UNIQUE NOT ENFORCED constraint |
| Previous Message | Michael Paquier | 2026-01-08 01:41:42 | Re: Fix for consume_xids advancing XIDs incorrectly |