| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Nikhil Kumar Veldanda <veldanda(dot)nikhilkumar17(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Burd, Greg" <greg(at)burd(dot)me>, Nikita Malakhov <hukutoc(at)gmail(dot)com>, Hannu Krosing <hannuk(at)google(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Support for 8-byte TOAST values (aka the TOAST infinite loop problem) |
| Date: | 2026-01-06 23:09:35 |
| Message-ID: | aV2WL3ciOySe0PLi@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Jan 04, 2026 at 11:39:28PM -0800, Nikhil Kumar Veldanda wrote:
> Semantics: the regression test accepts '-1040' and wraps modulo 2^64.
> Is that intentional? If yes, please document it; if not, oid8in()
> should reject negative input and the test should expect an error.
Yes, like for the oid type this is intentional.
> Nits: oid8.c appears to include <ctype.h> / <limits.h> without using
> them, and there’s an empty src/test/regress/expected/oid8.sql
> (intentional?).
Indeed, I'll clean up that. Thanks.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2026-01-06 23:11:13 | small cleanup of ICU includes |
| Previous Message | surya poondla | 2026-01-06 22:26:13 | Re: [PATCH] psql: tab completion for ALTER ROLE ... IN DATABASE ... |